Skip to content

Conversation

kgeilmann
Copy link
Contributor

Is your pull request related to a problem? Please describe.

Fixing the encoding related problems in tests of #2104

Describe the solution you have implemented

BannerTest, NoPublishFormatterTest, UrlReporterTest:
Using UTF-8 encoding in tests instead of relying on default encoding of the system, because otherwise the non-ascii characters are destroyed.

CommandLineOptionsParserTest:
Removed the line endings from the comparision, so moving to the same behaviour as other non-failing tests of the same class.

Additional context

@coveralls
Copy link

coveralls commented Oct 5, 2020

Coverage Status

Coverage remained the same at 86.481% when pulling 608231b on kgeilmann:fix_unittests_#2104 into bb97c69 on cucumber:main.

@mpkorstanje mpkorstanje changed the title Fix unittests #2104 [Core] Fix platform dependent unit tests Oct 6, 2020
@mpkorstanje mpkorstanje merged commit 4799b7c into cucumber:main Oct 6, 2020
@aslakhellesoy
Copy link
Contributor

Hi @kgeilmann,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@mpkorstanje
Copy link
Contributor

Cheers!

@kgeilmann kgeilmann deleted the fix_unittests_#2104 branch October 7, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants