[Core] Fix platform dependent unit tests #2145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 6, 2020 23:17
…t be deleted, thus failing the test
aslakhellesoy
requested changes
Oct 6, 2020
core/src/test/java/io/cucumber/core/plugin/PluginFactoryTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/io/cucumber/core/plugin/PluginFactoryTest.java
Outdated
Show resolved
Hide resolved
mpkorstanje
reviewed
Oct 7, 2020
core/src/test/java/io/cucumber/core/plugin/PluginFactoryTest.java
Outdated
Show resolved
Hide resolved
mpkorstanje
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your pull request related to a problem? Please describe.
Fixing the last test of #2104 and the PluginFactoryTest, which also fails on windows.
Describe the solution you have implemented
Ignore ResourceScannerTest#scanForResourcesPathSymlink on windows, because to make it run windows needs to be in developer mode, and the repo has to be cloned with actived symlinks.
The PluginFactory Test fails on windows, because the plugins (the real ones, not the test plugins) which get a file paramter, open the file directly during instantiation. On windows the test failed, because junit cannot delete the tmpDir due to open files. The change uses the EventPublisher to send events to the plugin, especially the TestRunFinished Event. During handling of TestRunFinished the plugins close the file and junit can successfully clean up afterwards.
Additional context
Add any other context or screenshots about the pull request here.