Skip to content

Conversation

adbatista
Copy link
Contributor

I cleaned The dead code from AST, the the tests in cucumber and cucumber-core are OK

attr_accessor :feature_element, :exception, :multiline_arg

INDENT = 2
attr_accessor :exception, :multiline_arg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these still both need to be mutable? Or would attr_reader suffice?

@mattwynne
Copy link
Member

@adbatista thanks for this, and sorry it's taken so long to give it full attention - bad time of year!

@tooky this LGTM, any comments?

@adbatista
Copy link
Contributor Author

No problem
I made the rabase from master branch and changed the attr_accessor :exception, :multiline_arg to attr_reader
the cucumber tests are all green

@tooky
Copy link
Member

tooky commented Jan 9, 2014

This looks fine from my POV.

thanks @adbatista.

Perhaps we should make sure the cucumber/cucumber tests still pass with this branch?

@adbatista
Copy link
Contributor Author

I executed the specs and features on cucumber/cucumber
they are all green

@mattwynne mattwynne merged commit 48df63c into cucumber:master Jan 10, 2014
@mattwynne
Copy link
Member

Thanks for your contribution @adbatista! I look forward to the next one 😄

@adbatista adbatista deleted the dead_code_from_AST branch January 15, 2014 18:13
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants