-
-
Notifications
You must be signed in to change notification settings - Fork 52
Dead code from ast #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
attr_accessor :feature_element, :exception, :multiline_arg | ||
|
||
INDENT = 2 | ||
attr_accessor :exception, :multiline_arg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these still both need to be mutable? Or would attr_reader
suffice?
@adbatista thanks for this, and sorry it's taken so long to give it full attention - bad time of year! @tooky this LGTM, any comments? |
No problem |
This looks fine from my POV. thanks @adbatista. Perhaps we should make sure the cucumber/cucumber tests still pass with this branch? |
I executed the specs and features on cucumber/cucumber |
Thanks for your contribution @adbatista! I look forward to the next one 😄 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I cleaned The dead code from AST, the the tests in
cucumber
andcucumber-core
are OK