Skip to content

Protobuf formatter #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 93 commits into from
Feb 18, 2020
Merged

Protobuf formatter #1387

merged 93 commits into from
Feb 18, 2020

Conversation

vincent-psarga
Copy link
Contributor

Summary

Emit Cucumber::Messages when running.

Details

Also includes validation based on cucumber-compatibility-kit.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Refactor (code change that does not change external functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@vincent-psarga
Add envelope event to emit cucumber-messages envelopes
9190984 
Add formatter listening to those events and printing it out
@vincent-psarga
Add feature file describing message formatter
248a8d8
@vincent-psarga
WIP: enable binary output
e36f8b4
@vincent-psarga
Rename MultilineArgument::DataTable.to_hash to MultilineArgument::Dat…
9d8d051 
…aTable.cells_to_hash

Create .to_hash method that returns a matrix of the cells values
@vincent-psarga
Merge branch 'add-envelope-event' into fire-events
7ca2ce0
@vincent-psarga
Merge branch 'fix-cucumber-wire-failing-tests' into fire-events
6b7b299
@vincent-psarga
Produce a TestCase event before its execution
e5dc6ba
@vincent-psarga
Fire envelopes when registering Hooks & step definitions
0dc28e1
@vincent-psarga
Emit more messages when running
bc9715a
@vincent-psarga
Merge branch 'master' into fire-events
a794bf2
@vincent-psarga
Drop some comments
0d1cdd7
@vincent-psarga
Add Makefile to copy features from CCK, run them and produce NDJSON
6a7e9ec
@vincent-psarga
CCK: compare messages with originals
ac599b8
@vincent-psarga
CCK: Add empty step definitions
58eb5f3
@vincent-psarga
Use correct branch for core
adaafa8
@vincent-psarga
Return correct value in register_rb_hook
ef8d19e
@vincent-psarga
Expect correct messages in features/docs/formatters/message.feature
5c283af 
Remove scenario about binary format, should be done when needed.
@vincent-psarga
Fix Rubocop offenses
3e11d2a
@vincent-psarga
CCK: Split step definitions across multiple files
9ad3b91
@vincent-psarga
CCK: use Rspec to compare generated messages
752b647
@vincent-psarga
Fix offenses
46eb502
@vincent-psarga
Do not run rubocop on generated CCK spec files
bf5c22f
@vincent-psarga
CCK: do not load all steps definitions
9fa7096
@vincent-psarga
Emit Source message
9d4a02a 
Fix various issues in cck Makefile
@vincent-psarga
Emit TestRunStarted/Finished messages
8e146d3
@vincent-psarga
Update message.feature so it shows really the expected messages
1603efb 
Moves step_definitions linked to messages to messages_step instead of json_steps
Fix some Rubocop offenses
@vincent-psarga
CCK: allow specify path the monorepo
975dd32
@vincent-psarga
Run CCK validation on CircleCI
e9af354
@vincent-psarga
CCK: do not count messages, contains_exactly does the same
45157b3
@vincent-psarga
CCK: no need to build monorepo, NDJSON files are in git
f97fd7f
@vincent-psarga
Fix typo in circleci config
f2148be
@vincent-psarga
CI: use cucumber image to build the monorepo
7dd5d45
@vincent-psarga
CCK: self-test require correctly step definitions
221c90f
@vincent-psarga
Fix default path to monorepo
d1721fd
@vincent-psarga
Make failed/pending stacktrace closer to original
20c10a3
@vincent-psarga
Update to latest CCK (with attachments)
02cdd8e
@vincent-psarga
CCK: generate JSON from CCK and compare with Ruby
75725cf
@vincent-psarga
CI: build cucumber-ruby on cucumber/cucumber-build image
aecc941
@vincent-psarga
CCK: attach bytes a byte (not int)
00e0e07
@vincent-psarga
Removing a "puts" left in JSON formatter that caused issue when compa…
57cbbe1 
…ring JSON outputs ...
@vincent-psarga
Copy json-formatter when is is updated in monorepo
05480d2
@vincent-psarga
No need to remove ouput (was due to an error left in json-formatter)
41925f6
@vincent-psarga
message formatter: no need to append backtrace to result, this is alr…
81d337c 
…eady done by Core::Test::Runner
@vincent-psarga
Use monorepo CCK for validation
07a8c20
@vincent-psarga
CI: clone correct branch for CCK validation
8476fe6
@vincent-psarga
CCK: need to build mono-repo for json-formatter
82495c8 
Building the Go mono-repo is now a job and is peristed to the workspace
@vincent-psarga
CI: fix typo when fetching mono-repo
3f1646d
@vincent-psarga
CI: use https to clone monorepo
f3d3152
@vincent-psarga
CI: speed up monorepo build
56f8a51
@vincent-psarga
CI: ensure libs for nokogiri are installed
8631d31
@vincent-psarga
CI: use correct path
9690927
@vincent-psarga
Update paths for acceptance tests
26f1e0e
@vincent-psarga
Bump to Gherkin 10 and messages 10
a09acf3
@vincent-psarga
Catch Cucumber::CucumberExpressions::UndefinedParameterTypeError and …
8ef5995 
…emit a Cucumber::Messages::UndefinedParameterType message.
@vincent-psarga
Fix Rubocop offense
1ee1fb4
@vincent-psarga
Update CHANGELOG
93355b5
@vincent-psarga
Don't use cucumber-ruby-core fire-events branch as this was merged
28d5ab3
@vincent-psarga vincent-psarga merged commit 30c01bc into master Feb 18, 2020
@cbochs cbochs mentioned this pull request Jan 11, 2021
Closed
@luke-hill luke-hill deleted the fire-events branch August 22, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincent-psarga @aslakhellesoy