Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date polyfill wipes out other changes to Date #11

Closed
jeffrose opened this issue Nov 1, 2012 · 2 comments
Closed

Date polyfill wipes out other changes to Date #11

jeffrose opened this issue Nov 1, 2012 · 2 comments
Assignees

Comments

@jeffrose
Copy link

jeffrose commented Nov 1, 2012

First, let me admit that aside from polyfill, code should not modifying the Date data type; however we cannot always choose the standards to which 3rd-party products implement their features.

Having said that, due the fact that date.js makes a copy of the Date data type, modifies it, and then sets Date to that modified copy, it wipes out any changes that are made to Date in the interim. This seems to go against the concept of "do no harm."

@unscriptable
Copy link
Member

fair point. let me take another look at that shim.

@unscriptable
Copy link
Member

this fix was finally released in 0.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants