Copy Date own props to new constructor if necessary #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,32 +133,32 @@ define(['./lib/_base'], function (base) { | |||
| } | |||
|
|
|||
| function checkIsoCompat () { | |||
| if (!isoCompat()) { | |||
There was a problem hiding this comment.
good catch to hoist the Date_ function out of the if block
There was a problem hiding this comment.
spacing: yep, will do. Hmmm, hoisting p, normally I'd say yes, but in this case, it's the only var in the function, and it'd need to be hoisted quite a distance. Ah, maybe hoisting p plus moving the new Date constructor to the bottom would help.
There was a problem hiding this comment.
wow, that's weird ... github attached this comment to the wrong line. I reloaded the page and the comment had moved!
|
thanks guys! |
unscriptable
added a commit
that referenced
this pull request
Nov 28, 2012
Copy Date own props to new constructor if necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11. Jared and I paired on this today, but didn't test in older IE yet. What do you think?