Change domReady to use callback instead of plugin

[ismell]

We need to use the callback instead of the plugin
because the plugin is constrained by the loaders
time out. So if the dom takes a while to load
then the loader will think the plugin failed
to load and cause it to time out.

[briancavalier]

Closing this after discussion, and opening #16 to track the domReady issue.

[briancavalier]

I just had a thought that might help your specific case, Raul. Did you try remapping wire/domReady directly to RequireJS's domReady module? Something like:

// RequireJS config
paths: {
    'wire/domReady': 'path/to/requirejs/domReady',
    // more paths ...
}

I think that should work, but let me know if you try it.

[briancavalier]

I just tested it to make sure, and it worked just fine. In fact, it means 1 less module to load (wire/domReady). This seems like a pretty reasonable alternative for situations like yours where DOMReady might cause module loading to fail. It definitely needs to be documented tho! I'll add that to #16

[ismell]

Currently our page builder does not support wiring specific paths. It only adds packages to the require config. Might have to try and integrate that in.

Thanks!

[unscriptable]

I read James's reply on your link, @ismell, but this sure feels like a requirejs bug to me. Anything called DOM-ready should be waiting for the DOM, not modules, imho.

[unscriptable]

fwiw, the dojo loader uses a timeout by default (when in a browser), but the config setting, waitSeconds, is 0 (disabled) by default, so it's effectively turned off.

[briancavalier]

FYI, just added to the wiki: Dealing with DOMReady