#96 - Adiciona atributo height na tag img dos banners de filmes na tela inicial #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guites
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Antes de subir as alterações, testei o score do lighthouse e verifiquei que ele tava reclamando de layout shift e falta de altura nas imagens:
Depois, carreguei o PR e verifiquei que as reclamações sairam, aumentando de 83 pra 94 o score de performance 🚀 !
@KozielGPC Muito obrigado pela contribuição!
|
@guites Bom demais!!! Eu que agradeço pelo espaço para poder contribuir! Quem sabe não apareço em mais umas issues por ai ahhahah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sobre
Conforme solicitado na issue #96, foi adicionado o atributo
heightàs tagsimgda página inicial que contém os banners dos filmes listadosPrints