fix: Don't fail in apiMode when getting 404 not-founds on the build ID [CSR-3062] #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56
Description
There was a bug in our useAPI mode where we where erroring out the action for notFound. This was already fixed for sharding mode as part of the initial release, but was missed. Applied the same change to ensure the command doesn't fail the action.
Demo
Here is the log output from a sample run retry with this branch: https://github.com/twk3/playwright-gh-actions-demo/actions/runs/17507043195/job/49732490763 note the action passes and all tests are run again despite the 404 in the last-failed action log
Manual Testing
useApi: true
, and settingprevious-ci-build-id
to something that isn't the actual build Id. (though the previous ci build id template doesn't have to be wrong for this to happen in the real world, the run just has to have not been created, maybe there was nothing to do, etc).