Create Io interface and refactor fs-specific code into NativeIo
#19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaspan
commented
Dec 26, 2023
|
ok sorry for the long delay. I pushed a couple changes. Look ok? I'm going to run this for a couple days just to be sure, as the command server unfortunately doesn't have any tests, and is fundamental to cursorless and pretty much all Talon-based VSCode usage 😅 |
pokey
changed the title
pokey
changed the title
Io interface and refactor fs-specific code into NativeIo
|
The changes look fine to me. |
pokey
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring supports the creation of a web versions of this extension, though it does not yet include one.