"last token inside" refers to tokens outside when there is only one token

[josharian]

"aaa"

"take last token inside air" selects the trailing ", not aaa. Similarly for first token. take every token inside is also entertaining.

Pretty sure this is a bug.

[pokey]

Weird. Yeah def a bug. That might be one of the least efficient ways to target aaa here. Kinda like the opposite of cursorless golf. Which might be kind of a fun game as well tbh 😄. Guessing this came up with multiple cursors? Or just hunting edge cases? 😄

[josharian]

multiple cursors :)

if I wanted to hunt edge cases, I would use a fuzzer. which we maybe should do one of these days. but today is not that day.

[pokey]

Yeah been thinking bout using a fuzzer

[josharian]

Just used https://github.com/CodeIntelligenceTesting/jazzer.js for something else small today. Not as good a finding bugs as the fuzzer I used to contribute to way back when--it appears to be missing literal collection and sonar--but all in all pretty solid. And very easy to get started. The harder part is figuring out what good first targets might be. Happy to brainstorm with you about that.

[AndreasArvidsson]

I did some digging and inside isn't even respected. We just fall back to the default iteration scope which is line.
"aaa" bbb in this example bbb is the final token.
@pokey This sounds like something is incorrect in our nested scope handler.

[pokey]

It is very likely yet another undesired consequence of

cursorless/packages/cursorless-engine/src/processTargets/modifiers/EveryScopeStage.ts

Lines 62 to 71 in 698559e

	if (
	scopes.length === 1 &&
	scopes[0].domain.contains(target.contentRange)
	) {
	// If the only scope that came back completely contains the input target
	// range, we treat the input as if it had no explicit range, expanding
	// to default iteration scope below
	scopes = undefined;
	}
	}

[AndreasArvidsson]

I think you are right. "take every token inside" has the same problem