Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vscode version checks #2274

Closed
3 tasks
pokey opened this issue Mar 26, 2024 · 0 comments · Fixed by #2305
Closed
3 tasks

Remove vscode version checks #2274

pokey opened this issue Mar 26, 2024 · 0 comments · Fixed by #2305

Comments

@pokey
Copy link
Member

pokey commented Mar 26, 2024

Our policy is to support VSCode versions up to a year old. Thus, we bumped our VSCode dependency version in #2273. We can take advantage of this step to remove the following:

  • (and the legacy code that uses this check)
  • "onView:cursorless.scopes",
    "onCommand:cursorless.command",
    "onCommand:cursorless.internal.updateCheatsheetDefaults",
    "onCommand:cursorless.private.logQuickActions",
    "onCommand:cursorless.keyboard.escape",
    "onCommand:cursorless.keyboard.modal.modeOff",
    "onCommand:cursorless.keyboard.modal.modeOn",
    "onCommand:cursorless.keyboard.modal.modeToggle",
    "onCommand:cursorless.keyboard.targeted.clearTarget",
    "onCommand:cursorless.keyboard.targeted.runActionOnTarget",
    "onCommand:cursorless.keyboard.targeted.targetHat",
    "onCommand:cursorless.keyboard.targeted.targetScope",
    "onCommand:cursorless.keyboard.targeted.targetSelection",
    "onCommand:cursorless.pauseRecording",
    "onCommand:cursorless.recomputeDecorationStyles",
    "onCommand:cursorless.recordTestCase",
    "onCommand:cursorless.recordOneTestCaseThenPause",
    "onCommand:cursorless.resumeRecording",
    "onCommand:cursorless.showCheatsheet",
    "onCommand:cursorless.showDocumentation",
    "onCommand:cursorless.showQuickPick",
    "onCommand:cursorless.takeSnapshot",
    "onCommand:cursorless.toggleDecorations",
    "onCommand:cursorless.showScopeVisualizer",
    "onCommand:cursorless.hideScopeVisualizer",
    "onCommand:cursorless.analyzeCommandHistory"
    (and the code in meta-updater that generates them)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant