Support clipboardPaste with actual range argument #2522
Assignees
Comments
github-merge-queue bot
pushed a commit
that referenced
this issue
Jul 30, 2024
For IDEs that don't have vscode specific copy and paste behavior I have now implemented a text edit basted copy and paste. This also gives us a starting platform if we want to try to implement vscodes behavior ourself. Fixes #2522 ## Checklist - [/] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [/] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [/] I have not broken the cheatsheet --------- Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TextEditorspecifies thatclipboardPastecan have a range argumentcursorless/packages/common/src/types/TextEditor.ts
Line 154 in e87b6e3
But the only place we actually call this we set selection beforehand and don't pass an argument
cursorless/packages/cursorless-engine/src/actions/PasteFromClipboard.ts
Line 46 in e87b6e3
Since paste uses a destination just passing a range to the editor isn't really enough for an ide implementation to do something properly.
We should probably have it set up so if
ide.capabilities.clipboardPasteis undefined we instead just useide.clipboard.readText()and perform a single edit instead of setting and reverting selections.The text was updated successfully, but these errors were encountered: