Skip to content

Document custom command action #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 31, 2025
Merged

Document custom command action #2921

merged 9 commits into from
May 31, 2025
+41 −4

Conversation

AndreasArvidsson
Copy link
Member

No description provided.

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner May 22, 2025 08:28
pokey
pokey reviewed May 29, 2025
View reviewed changes
Copy link
Member

@pokey pokey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, tho I'd still lean towards requiring a _v0 suffix so we're not locked in. I made some tweaks too

@AndreasArvidsson
Copy link
Member Author

@pokey Action updated with a x_ prefix.

Do we really want to call this action parsed instead of custom?

pokey
pokey previously approved these changes May 31, 2025
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with minor comment

@AndreasArvidsson AndreasArvidsson disabled auto-merge May 31, 2025 16:15
@AndreasArvidsson AndreasArvidsson merged commit 09f2776 into main May 31, 2025
15 checks passed
@AndreasArvidsson AndreasArvidsson deleted the customCommandDocs branch May 31, 2025 16:15
cursorless-bot pushed a commit that referenced this pull request May 31, 2025
@AndreasArvidsson @pokey
Document custom command action (#2921)
b325728 
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pokey pokey pokey left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndreasArvidsson @pokey