Use @cursorless/tree-sitter-wasms dependency
#103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
approved these changes
Apr 21, 2025
| @@ -0,0 +1 @@ | |||
| cp -r node_modules/@cursorless/tree-sitter-wasms/out parsers | |||
There was a problem hiding this comment.
Tempted to just include node_modules/@cursorless/tree-sitter-wasms/out directory in the extension bundle and read them in place to avoid this step but I don't feel strongly
There was a problem hiding this comment.
Yeah true, but doesn't matter really and we are gonna scrap this ext anyhow.
There was a problem hiding this comment.
I took a crack at this but it apparently isn't recommended and you do get an error
The following include patterns in the "files" property in package.json do not match any files packaged in the extension:
- node_modules/@cursorless/tree-sitter-wasms/out
Remove any include pattern which is not needed.
I think copying assets is fine.
github-merge-queue bot
pushed a commit
to cursorless-dev/cursorless
that referenced
this pull request
Apr 22, 2025
cursorless-bot
pushed a commit
to hands-free-vim/cursorless.nvim
that referenced
this pull request
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to cursorless-dev/cursorless#2898
Tested together with the above pull request