-
-
Notifications
You must be signed in to change notification settings - Fork 42
Removing tree sitter hack and upgrading dependencies #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing tree sitter hack and upgrading dependencies #32
Conversation
…to get the build going on mac M1
#29 Is why we can remove custom build script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me with a couple minor comments, but would be good for @wenkokke to have a look as well. Also, don't forget to
- update the README instructions
package.json
Outdated
@@ -2,7 +2,7 @@ | |||
"name": "parse-tree", | |||
"displayName": "Parse tree", | |||
"description": "Access document syntax using tree-sitter", | |||
"version": "0.18.1", | |||
"version": "0.19.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best not to bump version in the PR. I'll handle version bumping on release
@@ -71,44 +70,44 @@ | |||
"publish": "vsce publish patch" | |||
}, | |||
"devDependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Will-Sommers you're going to have a bunch of merge conflicts with #28; not sure how to handle. I'd be inclined to get this PR in because it's fairly mechanical, but you're probably then going to need to redo the pins on #28.
Hmm I tried to build and run this one locally, but when I run the extension, I get the following error message:
Is it working for you? cc/ @wenkokke |
Maybe its worth splitting the upgrade and the removal of the tree sitter hack. Update: works fine on my M1 mac. Built with docker. |
2214dca
to
fef064f
Compare
Thanks, I used this branch to be able to build on M1 (wasn't able to compile |
The error reported above comes from tree-sitter itself |
The patch for |
Closing in favour of #68, which is very similar, but doesn't bump things |
Upgrading dependencies to get the build going on mac M1