Skip to content

Removing tree sitter hack and upgrading dependencies #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

bra1nDump
Copy link
Contributor

Upgrading dependencies to get the build going on mac M1

@bra1nDump
Copy link
Contributor Author

#29 Is why we can remove custom build script

Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me with a couple minor comments, but would be good for @wenkokke to have a look as well. Also, don't forget to

  • update the README instructions

package.json Outdated
@@ -2,7 +2,7 @@
"name": "parse-tree",
"displayName": "Parse tree",
"description": "Access document syntax using tree-sitter",
"version": "0.18.1",
"version": "0.19.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best not to bump version in the PR. I'll handle version bumping on release

@pokey pokey linked an issue Jun 27, 2022 that may be closed by this pull request
@@ -71,44 +70,44 @@
"publish": "vsce publish patch"
},
"devDependencies": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Will-Sommers you're going to have a bunch of merge conflicts with #28; not sure how to handle. I'd be inclined to get this PR in because it's fairly mechanical, but you're probably then going to need to redo the pins on #28.

@pokey
Copy link
Member

pokey commented Jun 29, 2022

Hmm I tried to build and run this one locally, but when I run the extension, I get the following error message:

rejected promise not handled within 1 second: RuntimeError: abort(Assertion failed: undefined). Build with -s ASSERTIONS=1 for more info.
/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:102
stack trace: RuntimeError: abort(Assertion failed: undefined). Build with -s ASSERTIONS=1 for more info.
	at oe (/Users/pokey/src/vscode-parse-tree/node_modules/web-tree-sitter/tree-sitter.js:1:6761)
	at k (/Users/pokey/src/vscode-parse-tree/node_modules/web-tree-sitter/tree-sitter.js:1:4462)
	at he (/Users/pokey/src/vscode-parse-tree/node_modules/web-tree-sitter/tree-sitter.js:1:7991)
	at xe (/Users/pokey/src/vscode-parse-tree/node_modules/web-tree-sitter/tree-sitter.js:1:9810)
	at /Users/pokey/src/vscode-parse-tree/node_modules/web-tree-sitter/tree-sitter.js:1:47405
	at runMicrotasks (<anonymous>)
	at processTicksAndRejections (node:internal/process/task_queues:96:5)

Is it working for you? cc/ @wenkokke

@bra1nDump
Copy link
Contributor Author

bra1nDump commented Jun 30, 2022

Maybe its worth splitting the upgrade and the removal of the tree sitter hack.

Update: works fine on my M1 mac. Built with docker.

@bra1nDump bra1nDump force-pushed the remove-web-tree-sitter-hack branch from 2214dca to fef064f Compare July 5, 2022 03:06
@phillco
Copy link
Member

phillco commented Jul 23, 2022

Thanks, I used this branch to be able to build on M1 (wasn't able to compile web-tree-sitter otherwise)

This was referenced Jul 23, 2022
@wenkokke
Copy link
Contributor

@wenkokke
Copy link
Contributor

The patch for 0.20.4 includes the ___cxa_atexit, which is needed by one of the languages, so moving away will likely break things.

@pokey
Copy link
Member

pokey commented Sep 27, 2023

Closing in favour of #68, which is very similar, but doesn't bump things

@pokey pokey closed this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to published version of web-tree-sitter-0.20.5
4 participants