Refactoring OAuth2 service #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This became a bit bigger than expected, but: * Refactors the OAuth2 service to have more consistent function signatures. * Adds token statistics to the oauth2 homepage. * Stores the 'grant_type' and whether a 'secret' was used in the tokens table. * We're now storing 'scope' for every token. This OAuth2 feature wasn't really used by this server, but this sets up the first steps for this. * Fixes a bug related to generating principal uris in the introspection endpoints. * Has more explicit support for the 2 a12nserver-specific oauth2 flows: "developer tokens" and "one-time-tokens". Other side-effects of this PR: * A few step furthers in #405 * Some progress towards OpenID Connect support (scopes are important for this).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This became a bit bigger than expected, but:
Other side-effects of this PR: