Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the ability to use path-match in the whitelist array #9

Closed
wants to merge 1 commit into from

Conversation

mihok
Copy link

@mihok mihok commented Oct 9, 2020

Scenario

Imagine having a website where part of the site is dynamic but still required to be public (not requiring authentication) Currently this would require manually restarting/editing the whitelist option since it is a simple string check. This is somewhat possible by setting the top level path /some/path allowing public access to all of the subpaths beyond that (e.g. /some/path/that/is/open)

I have a situation where I need to protect information about our customers, so sharing the entire collection /merchant is not feasible. I also want to allow public access to the clients menus, /merchant/X/menu but I cant do this with the whitelist today.

Changes

I've added the path-match library to enable parameterized whitelabel, essentially wildcard whitelabels.

@mihok mihok requested a review from evert October 9, 2020 13:05
@mihok
Copy link
Author

mihok commented Oct 9, 2020

I have a better PR for this. Closing

@mihok mihok closed this Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant