Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixes and support for single proxy without removal #26

Closed
wants to merge 21 commits into from

Conversation

tmendo
Copy link

@tmendo tmendo commented Mar 23, 2015

Hi,
I forked your code because I needed to add a single proxy that is not removed upon failure, so I can use pystemon with TOR (which uses a SOCKS proxy, so it needs to be combined with something like delegate that converts HTTP to SOCKS).

In addition I implemented some bug fixes (in bold the ones I consider more important):

  • update-min and update-max are now honoured
  • added option to enable or disable proxy use
  • added option to enable single or random proxy (random proxies are still removed after a few errors)
  • disabled redis by default
  • redis dependency only loaded if redis is enabled

Since I forked from other fork, this pull also has the following bug fixes:

  • prevent dead lock when multiple threads want to remove the same proxy server
  • fix encoding problem when sending alert by email
  • bugfix for empty textarea on snipt.net
  • replaced deprecated method from BeautifulSoup
  • added file listener for proxy list and made proxy list a unique set
  • bugfix in user agent management

@cvandeplas cvandeplas closed this in bb026bc Mar 7, 2020
@cvandeplas
Copy link
Owner

thank you very much.
I believe most of the fixes were already included/merged separately.
I have implemented the proxy feature a bit differently, but it achieves the same result: the system will not remove the last proxy, even if it's failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants