Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation with brushing tools #5269

Merged
merged 19 commits into from
Nov 18, 2022
Merged

Annotation with brushing tools #5269

merged 19 commits into from
Nov 18, 2022

Conversation

mdacoca
Copy link
Contributor

@mdacoca mdacoca commented Nov 10, 2022

Motivation and context

Added annotation with brushing tools topic

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev
Copy link
Member

Can you add a couple of lines about using AI tools with "Convert mask to poly" option?
You can use this detector on app.cvat.ai:

image

Detectors need to be rebuild on this server first. I will look into this.

Copy link
Contributor

@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me. Probably, 2 more things:

  • the imperative speech looks harsh to my taste. From my point, we should describe what the tools to and not what the user must do. It's just my preference, I don't insist.
  • Probably, it's better to rename files from brushing to brush after the page text

Page name changed from "brushing tools" to "brush tool"
@nmanovic
Copy link
Contributor

@mdacoca , could you please fix issues from the remark linter?

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need to find a way to share icons between the UI and documentation. I don't like how we prepare them now.

@nmanovic nmanovic merged commit 7944ef8 into cvat-ai:develop Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants