-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotation with brushing tools #5269
Conversation
site/content/en/docs/manual/advanced/annotation-with-brushing-tools.md
Outdated
Show resolved
Hide resolved
site/content/en/docs/manual/advanced/annotation-with-brushing-tools.md
Outdated
Show resolved
Hide resolved
site/content/en/docs/manual/advanced/annotation-with-brushing-tools.md
Outdated
Show resolved
Hide resolved
site/content/en/docs/manual/advanced/annotation-with-brushing-tools.md
Outdated
Show resolved
Hide resolved
site/content/en/docs/manual/advanced/annotation-with-brushing-tools.md
Outdated
Show resolved
Hide resolved
site/content/en/docs/manual/advanced/annotation-with-brushing-tools.md
Outdated
Show resolved
Hide resolved
site/content/en/docs/manual/advanced/annotation-with-brushing-tools.md
Outdated
Show resolved
Hide resolved
site/content/en/docs/manual/advanced/annotation-with-brushing-tools.md
Outdated
Show resolved
Hide resolved
site/content/en/docs/manual/advanced/annotation-with-brushing-tools.md
Outdated
Show resolved
Hide resolved
site/content/en/docs/manual/advanced/annotation-with-brushing-tools.md
Outdated
Show resolved
Hide resolved
site/content/en/docs/manual/advanced/annotation-with-brushing-tools.md
Outdated
Show resolved
Hide resolved
site/content/en/docs/manual/advanced/annotation-with-brushing-tools.md
Outdated
Show resolved
Hide resolved
site/content/en/docs/manual/advanced/annotation-with-brushing-tools.md
Outdated
Show resolved
Hide resolved
site/content/en/docs/manual/advanced/annotation-with-brushing-tools.md
Outdated
Show resolved
Hide resolved
site/content/en/docs/manual/advanced/annotation-with-brushing-tools.md
Outdated
Show resolved
Hide resolved
updated based on comments
updated overview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good to me. Probably, 2 more things:
- the imperative speech looks harsh to my taste. From my point, we should describe what the tools to and not what the user must do. It's just my preference, I don't insist.
- Probably, it's better to rename files from
brushing
tobrush
after the page text
Page name changed from "brushing tools" to "brush tool"
@mdacoca , could you please fix issues from the remark linter? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we need to find a way to share icons between the UI and documentation. I don't like how we prepare them now.
Motivation and context
Added annotation with brushing tools topic
How has this been tested?
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.