Skip to content

Conversation

hughsaunders
Copy link
Contributor

This changelog is maintained according to the format specified by
keepachangelog.

Related: #24

@hughsaunders hughsaunders requested a review from izgeri March 4, 2020 15:52
Copy link
Contributor

@izgeri izgeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine - but before we merge, can you please also:

  • Remove CHANGES.md
  • Add a parse-a-changelog pipeline step (like in this secretless commit) to validate that the CHANGELOG keeps to this standard over time

@hughsaunders hughsaunders force-pushed the cyberark-bash-lib-24 branch 5 times, most recently from d2754b9 to 3078a74 Compare March 6, 2020 16:42
This changelog is maintained according to the format specified by
keepachangelog.

Related: #24
@hughsaunders hughsaunders force-pushed the cyberark-bash-lib-24 branch from 3078a74 to bde2b42 Compare March 6, 2020 16:57
@hughsaunders hughsaunders requested a review from izgeri March 6, 2020 17:01
Copy link
Contributor

@izgeri izgeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


stage('Validate Changelog'){
steps{
parseChangelog()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snazzy!

@izgeri izgeri merged commit f879e54 into master Mar 6, 2020
@izgeri izgeri deleted the cyberark-bash-lib-24 branch March 6, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants