Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose excursion avatar from image pool #4

Closed
atd opened this issue Mar 2, 2012 · 5 comments
Closed

Choose excursion avatar from image pool #4

atd opened this issue Mar 2, 2012 · 5 comments
Assignees

Comments

@atd
Copy link
Contributor

atd commented Mar 2, 2012

No description provided.

@rafaelgg
Copy link
Contributor

rafaelgg commented Mar 2, 2012

TBD: should Avatars_for_rails target ActivityObject rather than Actor in Social Stream? What are the technical challenges in refactoring this? Are we willing to do it?

If so, this bug maybe pertains more to Social Stream than ViSH; otherwise we can modify Avatars or just re-implement and avoid reusing it altogether (which would be a pity).

@rafaelgg
Copy link
Contributor

It seems like we won't be using Avatars_for_rails after all.

I commited some code to let each excursion have a thumbnail from the pool (thanks @diegocarrera for the really nice pics), but we should write a view and maybe patch the excursion controller to let users choose. OTOH there's no way to choose an excursion title or description yet, so don't hold your breath.

@atd
Copy link
Contributor Author

atd commented Mar 22, 2012

Acording to @ntoribio this will be integrated in the vish_editor, along with title and description

@ghost ghost assigned ebarra May 7, 2012
@rafaelgg
Copy link
Contributor

rafaelgg commented May 7, 2012

We just assigned a random thumbnail to each excursion in our production system. These may be changed when we acquire this functionality.

vish_editor team to take care of this.

@raquelgb
Copy link
Contributor

This is working since ff18421. Closing.

crispinh2o pushed a commit that referenced this issue Sep 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants