New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Reacter model's hasReactedTo & hasNotReactedTo methods signature #111

Merged

antonkomarev merged 2 commits into master from fix/reacter-boolean-methods-signature

Sep 3, 2019

Member

antonkomarev commented Sep 3, 2019 •

edited

Loading

For the consistency reason change float $rate = null parameter to ?float $rate = null in Reacter models.

Despite the fact this PR changes the contract - it will be released in minor version because it's fully backward compatible.


          Fix Reacter model's hasReactedTo & hasNotReactedTo methods signature

94112fb

antonkomarev added the enhancement label

antonkomarev added this to the v8.1.0 milestone


          Update changelog

e589b5c

antonkomarev merged commit 7c1b0c8 into master

antonkomarev deleted the fix/reacter-boolean-methods-signature branch

September 3, 2019 07:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels