Trans

[opotowsky]

Perhaps @gidden should check to make sure this is doing what he wants. This is basically listing all the simulation info / commodity and its mass. If correct, this will close issue #55

[gidden]

Thanks for getting to this so quickly, @opotowsky! Comments inline.

[gidden]

At a minimum, I would use Qty vs. Quant here to match similar usage across the project. I might further suggestion shortening to TransQty. Is there any official metric name style guidance?

[opotowsky]

There is not! I welcome any and all input since it looks like this will be a part of the 1.3 release (you can skim metrics.py right now since the PR for online documentation is still waiting on input).

Thank you for the suggestion here, I will make the change.

[scopatz]

I wouldn't use either. Just spell out Quantity.

[opotowsky]

Should I then update other shortened names? ElectricityGen comes to mind.

[scopatz]

Probably. But that is a separate PR. Unless an abbreviation is approved by the style guide or in the docs, it should not be used. Currently we have no approved abbreviations.

[opotowsky]

Understood. Thanks!

[opotowsky]

Alright @gidden, I think I addressed everything!

[gidden]

excuse my ignorance, but will the interface require an update when you generalize the Mass metric, or is that all implementation?

[opotowsky]

I left Mass as is, except I added the units column to the metric, since generalizing it would require a rename (so I can just add a general metric another time). I just generalized TransactionQuantity here.

[gidden]

I guess what I'm saying is that the term Mass should be kept in the implementation and that the user-facing key should be Quantity. Including Units is definitely helpful and appreciated.

[gidden]

so here the schema key should be Quantity and not Mass

[opotowsky]

OH! My oversight. Thanks. I'll change this to Quantity for the schema

[opotowsky]

Finally, all ready @gidden

[gidden]

looks good, thanks @opotowsky