Quickfix #77
Quickfix #77
Conversation
Conflicts: .travis-install.sh .travis.yml
|
Pinging @gidden @rwcarlsen @mbmcgarry @scopatz for review; not sure if this is an appropriate solution for 1.3.newer! |
| @@ -908,12 +908,13 @@ def parse_args(argv): | |||
| def setup(ns): | |||
| """Ensure that we are ready to perform code generation. Returns typesystem.""" | |||
| # load raw table | |||
| dbtypes_json = os.path.join(ns.build_dir, 'dbtypes.json') | |||
| dbtypes_json = os.path.join(ns.src_dir, 'dbtypes.json') | |||
There was a problem hiding this comment.
is there a reason this has to be in the src_dir? why not hold the .js file and write the json file to the build dir? that would keep things "mostly" the same.
There was a problem hiding this comment.
I guess I assumed that the .js and .json files should be together, but that was probably silly to assume! I'll update it to be created in the build directory.
There was a problem hiding this comment.
The .js file is input and the json file is the result of some processing
(and can be easily regenerated).
On Fri, Jun 5, 2015 at 1:03 PM, opotowsky notifications@github.com wrote:
In genapi.py
#77 (comment):@@ -908,12 +908,13 @@ def parse_args(argv):
def setup(ns):
"""Ensure that we are ready to perform code generation. Returns typesystem."""
# load raw table
- dbtypes_json = os.path.join(ns.build_dir, 'dbtypes.json')
- dbtypes_json = os.path.join(ns.src_dir, 'dbtypes.json')
I guess I assumed that the .js and .json files should be together, but
that was probably silly to assume! I'll update it to be created in the
build directory.—
Reply to this email directly or view it on GitHub
https://github.com/cyclus/cymetric/pull/77/files#r31836270.
Matthew Gidden, Ph.D.
Postdoctoral Associate, Nuclear Engineering
The University of Wisconsin -- Madison
Ph. 225.892.3192
|
This is not a good fix because it duplicated information across different sources in the ecosystem. Preferably they should be only one canonical location (aside from the source code itself) where this information is garnered from. The correct fix is in cyclus/cyclus.github.com#157 |
No description provided.