Skip to content

Conversation

saramontif
Copy link
Contributor

No description provided.

Copy link
Collaborator

@MarshalX MarshalX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Pls add support for JSON printer and update branch

Copy link
Collaborator

@MarshalX MarshalX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add support for JSON printer and update branch

Copy link
Collaborator

@MarshalX MarshalX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table output still return many report url. probably because of described conversations below. pls update branch. everything else is good!

@MarshalX MarshalX changed the title CM-34882-Add support one report url CM-34882 - Add one report URL for all secrets found in the same scan May 23, 2024
@MarshalX
Copy link
Collaborator

pls update our e2e tests for CLI after merging. they will probably break because of changes in printers. 'Report URL' instead of 'Report URLs:`

@saramontif saramontif merged commit 8b91279 into main May 28, 2024
@saramontif saramontif deleted the CM-34882-support-one-report-url branch May 28, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants