Analysis view: box & whiskers plot #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
force-pushed
the
analysis
branch
7 times, most recently
from
93128ae
to
4597e49
Compare
Co-authored-by: Christopher Bennett <christopher.bennett@metoffice.gov.uk>
This comment was marked as resolved.
This comment was marked as resolved.
MetRonnie
force-pushed
the
analysis
branch
2 times, most recently
from
2b4108c
to
ec157f4
Compare
It was only catching it in vite serve but not the final build
There was a problem hiding this comment.
Looks good, works well, seems robust.
A few small points:
It would be good to give units with these times (i.e. seconds), worth bearing in mind that we might want to customise the display of these times in the future (e.g. 45s, 10m, 1:20, PT4H31M, etc):
I managed to get a null Q1 time where it didn't make sense:
It's not completely clear what the chart is displaying, e.g. what do the blue/green numbers mean, especially when there is little spread in the times so far:
8 tasks
|
The null entries are caused by a bug in the SQL in the UI Server. |
MetRonnie
force-pushed
the
analysis
branch
2 times, most recently
from
23c047c
to
4f0e080
Compare
10 tasks
Co-authored-by: ChrisPaulBennett <christopher.bennett@metoffice.gov.uk>
MetRonnie
added
the
data workflows team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1290
I've extracted out the relevant diff from #1290 and tidied it up / built upon it
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.CHANGES.mdentry included if this is a change that can affect users