Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Auto collapse single task workflows #889

Closed

Conversation

AaronDCole
Copy link
Contributor

These changes partially address #865

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Appropriate tests are included (unit and/or functional).
  • Already covered by existing tests.
  • Does not need tests (UI change).
  • Appropriate change log entry included.
  • No change log entry required (why? e.g. invisible to users).
  • I have opened a documentation PR at cylc/cylc-doc/pull/XXXX.
  • No documentation update required.

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2022

Codecov Report

Merging #889 (4827cb1) into master (1dd6dd1) will decrease coverage by 14.95%.
The diff coverage is 14.49%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #889       +/-   ##
===========================================
- Coverage   91.24%   76.29%   -14.96%     
===========================================
  Files          92       92               
  Lines        1930     1995       +65     
  Branches      114      147       +33     
===========================================
- Hits         1761     1522      -239     
- Misses        143      453      +310     
+ Partials       26       20        -6     
Flag Coverage Δ
e2e 76.29% <14.49%> (-2.26%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/cylc/Drawer.vue 75.00% <ø> (ø)
src/components/cylc/gscan/GScan.vue 72.72% <0.00%> (-21.03%) ⬇️
src/components/cylc/tree/Tree.vue 52.94% <0.00%> (-31.91%) ⬇️
src/views/Table.vue 100.00% <ø> (ø)
src/views/Tree.vue 100.00% <ø> (ø)
src/views/Workflow.vue 92.85% <ø> (ø)
src/components/cylc/table/Table.vue 30.30% <6.66%> (-69.70%) ⬇️
src/components/cylc/table/deltas.js 45.33% <16.66%> (-37.75%) ⬇️
src/components/cylc/gscan/filters.js 78.94% <55.55%> (-21.06%) ⬇️
src/components/cylc/gscan/sort.js 11.11% <0.00%> (-88.89%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dd6dd1...4827cb1. Read the comment docs.

@oliver-sanders
Copy link
Member

oliver-sanders commented Jan 21, 2022

Installing and cleaning three runs to see the auto collapse at work:

gscan-collapse

Nice! I think users will really appreciate this.

Only suggestion is that it might be clearer to keep the tree expand button for collapsed workflows to make it clearer that they have been collapsed? But the slash in the workflow name does cover that nicely.

Something odd is going on with the status boxes:

Screenshot 2022-01-21 at 09 01 42

Otherwise great!

@hjoliver
Copy link
Member

Nice 👍

@MetRonnie MetRonnie added this to the 1.x milestone Feb 7, 2022
@AaronDCole AaronDCole force-pushed the auto-collapse-single-task-workflows branch from 4827cb1 to b700d88 Compare February 8, 2022 21:08
@oliver-sanders oliver-sanders modified the milestones: 1.x, 1.1 Feb 16, 2022
@AaronDCole AaronDCole closed this Feb 17, 2022
@AaronDCole AaronDCole deleted the auto-collapse-single-task-workflows branch February 17, 2022 11:04
@hjoliver
Copy link
Member

Superseded by #938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants