Skip to content

feat: print coverage counters in the reporter #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bahmutov
Copy link
Contributor

To quickly see the coverage after each test

Screen Shot 2019-09-10 at 10 01 00 AM

I think it looks kind of nice, here is TodoMVC

Screen Shot 2019-09-10 at 10 08 49 AM

@bahmutov bahmutov requested a review from flotwig September 10, 2019 14:10
return null
// count current code coverage
const counters = {
s: 0,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of s, f, b, could statements, functions, branches be used instead? The short names are kinda obscure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, I will keep the one letter properties, since they match the coverage object properties, but will add comments

return
}
cy.task('combineCoverage', coverage).then(response => {
cy.log(`**${response.covered.s}**/**${response.total.s}** statements`)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@bahmutov bahmutov Sep 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good observation about logs test, I might start creating test subfolders with test projects. It will be hard to test everything since most of the stuff happens after each or after all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants