Skip to content

Conversation

calvinballing
Copy link
Contributor

The window example in the recipe list does not use spy, it uses stub. The recipe list incorrectly identifies it as using spy. I have updated this reference to be stub.

Translations updated

Changes made to documentation were also copied over to other languages (copying English text is ok).

  • Japanese docs in /source/ja.
  • Chinese docs in /source/zh-cn.
  • Not applicable (this is not a change to an en doc content).

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good catch 💯

@jennifer-shehane jennifer-shehane merged commit 849a8f9 into cypress-io:develop Jun 10, 2019
jennifer-shehane pushed a commit that referenced this pull request Jun 21, 2019
* Moved Custom Reporters section to bottom the page

To improve usability.

* Added link to Section 9 (reporters) of workshop

* fix link to demo-docker-cypress-included repo, close #1743

* add Aurelia CLI to framework tooling plugins

* add code-coverage plugin

* chore(deps): update dependency husky to version 2.4.0 🌟 (#1748)



Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update dependency lint-staged to version 8.2.0 🌟 (#1749)



Co-authored-by: Renovate Bot <bot@renovateapp.com>

* Maintenance of docs content (#1751)

* update existing history tables to link to changelog + remove leading |

* add missing iscy.md to japanese files

* Add history tables to more pages

* Add text lint rules for URL and HTML to always be allcaps

* wip converting markdown image tags to imgTag + replacing outside hosted images with own hosted images

* Fix more imgTags and headers in en/ja files

* Added more names/brands to testlint + fixes

* Fix misuse of compliment when meaning complement

* Replace ableist terms, recommend better terms in linting

* convert more image tags / headers

* Add textlint rules for CORS, cross-origin, and Develop Tools (use generic instead of Chrome brandname)

* Fix broken links due to lint conversions

* Fix more imgTags + headers

* Updating more imgTag + headers

* Set textlint rules + fixes for XHR, localStorage, sessionStorage and iframe

* finish replacing all imgTags and headers

* remove unused sidebar links/translations + add japanese title to all ja docs

* Fix words missing first char in chagelogs

- Add more history tables
- Add some missing documentation after reading changelogs

* remove moment from textlint, fix incorrect uses of moment.

- Add WebSocket/WebSockets, iframes, HTTP / HTTPS, SSO to textlint
- Remove use of word 'simply' and add to textlint

* Fix Cypress' pluralization

* Plugins - Add cypress-unfetch (#1750)

* cypress-unfetch

* cypress-unfetch plugin for en, ja and zh-cn

* emphasize copying English is ok for PR template

* fix(deps): Update dependency hexo-algoliasearch to version 0.3.2 🌟 (#1755)



Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update dependency to version 🌟 (#1756)



Co-authored-by: Renovate Bot <bot@renovateapp.com>

* update area of screenshots and videos to link to visual testing guide (#1757)

* update area of screenshots and videos to link to visual testing guide

- Also mention that video capturing is only supported in electron.

* Add visual testing guide to other sections of docs

* Change: 'spy' -> 'stub' for 'window' recipe (#1759)

* typo "can not" -> "cannot"

* typo "can not" -> "cannot"

* typo "can not" -> "cannot"

* typo "can not" -> "cannot"

* typo "can not" -> "cannot"

* typo "can not" -> "cannot"

* add ["can[- ]not", "cannot$1"]

add ["can[- ]not", "cannot$1"] to change "can not" to "cannot"

* its -> it is

* its -> it's

* its -> it is

* Update url_generator.js

* Fix typo reenable > reenabled

* Fix typo reenable > reenabled

* Change: 'spy' -> 'stub' for 'window' recipe

* Change: 'spy' -> 'stub' for 'window' recipe

* Change: 'spy' -> 'stub' for 'window' recipe

* write code coverage guide (#1744)

* start code coverage guide

* write section about instrumenting code

* add code coverage to Ja sidebar

* more content for code coverage document

* finish section on unit testing

* Add Istanbul to textlintrc

* Editing / add intro paragraph

* package-lock

* woops, fixed some of the code formatters

* fix DevTools term

* write introduction section

* add blank line to pass linter

* Add code coverage docs to ja/cn

* fix missing image in launching browsers guide

* add logging in using JWT recipe link (#1762)

* chore(deps): Update dependency husky to version 2.4.1 🌟 (#1764)



Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): Update dependency gulp-rev-all to version 2.0.2 🌟 (#1760)



Co-authored-by: Renovate Bot <bot@renovateapp.com>

* add code coverage webpack-dev-server example link

* chore(deps): update dependency lint-staged to version 8.2.1 🌟 (#1770)



Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update dependency @types/jest to version 24.0.14 🌟 (#1767)



Co-authored-by: Renovate Bot <bot@renovateapp.com>

* Add Cypress courses page (#1766)

* start courses page

* add spanish language course

* add pluralsight

* add second udemy course

* Remove courses template - move into media template

- Try to fix up layout of courses to look nicer

* Fix up courses placement + layout, add intro paragraph

* Add new podcast

* Add specific messages for when tests failing that loop through languages fail - print lang it failed on.

* Copy courses content over to translated docs


Co-authored-by: Jennifer Shehane <jennifer@cypress.io>

* add section to debugging on how to change test runner code (#1769)

* add section to debugging on how to change test runner code

* Edit debug instructions

- call it 'installed Cypress code'
- Link to cache path command
- Do not include 'code' command - this will confuse users if it doesn't work copy/paste, just tell them to open it in their code editor

* copy new debug content to translated docs


Co-authored-by: Jennifer Shehane <jennifer@cypress.io>

* add screenshot how to change browser (#1768)

* add screenshot how to change browser

* copy to ja and cn

* minor editing


Co-authored-by: Jennifer Shehane <jennifer@cypress.io>

* add xebia training course (#1773)

* chore(deps): Update dependency snap-shot-it to version 7.7.0 🌟 (#1775)



Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update dependency @types/jest to version 24.0.15 🌟 (#1776)



Co-authored-by: Renovate Bot <bot@renovateapp.com>

* Add npm-cy to plugins

* Add alias example for cy.request()

* Add Chinese translated titles to docs

* fix(deps): update dependency hexo to version 3.9.0 🌟 (#1777)



Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update dependency snap-shot-it to version 7.7.1 🌟 (#1785)



Co-authored-by: Renovate Bot <bot@renovateapp.com>

* Update debugging.md (#1784)

* update fragment sentence fix to ja/cn docs

* 📝 Include a much simpler TypeScript example (#1745)

* 📝 Include much simple TypeScript example

There was an overload of information in these docs (and example recipes)
and it took me several hours to set-up something that was relatively
simple if it was communicated better. Feel free to fork the repo I
put in the links. Please put something this simple in these docs.

* 👌 Changes according to PR reviewer

Changed typescript to TypeScript

* Fixed bad url tag in reporters page

* Moved Custom Reporters section to bottom the page

To improve usability.

* Added link to Section 9 (reporters) of workshop

* Fixed bad url tag in reporters page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants