Add hash scroll offset #1945
Merged
Add hash scroll offset #1945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
jennifer-shehane
previously approved these changes
Aug 1, 2019
amirrustam
previously approved these changes
Aug 1, 2019
|
@TonySynenko resolve that last conflict, and then feel free to squash & merge this in. |
# Conflicts: # package-lock.json
jennifer-shehane
dismissed stale reviews from amirrustam and themself
via
fb91d3a
jennifer-shehane
pushed a commit
that referenced
this pull request
Aug 5, 2019
* Adding HTML form validation to FAQ, closes #1824 (#1919) * update ja/cn docs to match develop changes * parseSpecialCharSequences docs (#1886) * Add file for 3.5.0 changelog * Added documentation for disableSpecialCharSequences option for… (#1885) * Added documentation for disableSpecialCharSequences option for cy.type * update description of disableSpecialChar... to be more active voice Co-authored-by: Jennifer Shehane <jennifer@cypress.io> * rename `disableSpecialChars` opions (#1903) * Revert "Added documentation for disableSpecialCharSequences option for… (#1885)" This reverts commit 298df85. * rename disableSpecialCharSequences * fix description of 'parseSpecial...' - was opposite meaning, still mentioned disable - Add notes about how to disable special char sequences in more places in type doc. * Remove changelog so I can just commit new feature changes * chore(deps): update dependency @types/jest to version 24.0.16 🌟 (#1920) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Jennifer Shehane <jennifer@cypress.io> * Update continuous-integration.md (#1912) * copy changes to ja/cn file * Add elm-batteries project template to plugins (#1925) * chore(deps): Update dependency to version 🌟 (#1929) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Add example of setting 'parseSpecialCharSequences' to false (#1927) * update wait requirements to specify when it can be used as chil… (#1930) - also alphabetize requirements methods * Improve GitHub integration "run group" link target (#1924) * Improve GitHub integration "run group" link target * Update ja locale link * Update zh-cn locale link * Use internal link syntax * chore(deps): update dependency husky to version 3.0.2 🌟 (#1922) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Remove deps that appear to be unused (mostly devDeps) (#1931) * Clarify some of the options available in Module API (#1934) * Add contentful based top banner (#1911) * data fetch && swig && styles * banners actualization script * finish (?) * finish (?) * remove "extends" from eslint settings * remove sensitive info * update hexo index file * banner padding fix * remove Promise.protoype.finally() from hexo index script * Contentful driven banners, parsed dynamically: Hexo index.js && data fetch && swig && styles && banners_actualization script * add cypress test for banners * docs update v1 * Fix toc width so that it doesn't create a horizontal scrollbar on smaller heights screen. * package-lock * just a few tweaks to the README instructions * fixed conflict issue from package.json merge * add GitHub Enterprise integration support notice (#1936) * add GitHub Enterprise integration support notice * add japanese and chinese versions * remove remove package that was accidentally installed * Update banner tests to be more resilient to changes in content - instead of regex removals, use utf8 encode the html content provided - use Cypress commands instead of direct javascript - so we can have better logs during CI runs and also have retryability. * package-lock * Handle html entities also - Basically - we’re done parsing that HTML, what a mess. Only going to parse the text within the HTML now for the tests. - Add an html entity within the banners.yml so we make sure these are tested. * Add a catch handler to the contenful.getEntries - that will continue to run hexo.init if failed * gitignore banners.yml?? * Header partial cache removal (#1937) Co-authored-by: null <anthony.synenko@gmail.com> * Fix issue with righthand toc slipping under header during test * add cy.get by name attribute example (#1941) * add cy.get by name attribute example * copy to ja/cn Co-authored-by: Jennifer Shehane <jennifer@cypress.io> * add robots.txt and copy it to public folder during build (#1942) * add robots.txt and copy it to public folder during build * add robots.txt test * add custom methods on Cypress for checking env name * switch another spec to use method * Add hash scroll offset (#1945) * temporary workaround for hash scroll * Add tests to ensure the docs scroll properly when clicking on a toc link Co-authored-by: null <anthony.synenko@gmail.com> Co-authored-by: Jennifer Shehane <jennifer@cypress.io> * Add mobile header fix (#1949) * temporary workaround for mobile header * scroll container to top * toc fix * Add note for <-loopback> usage * Update proxy-configuration.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add temporary workaround for hash scroll