Skip to content

Fix the use of the #Visiting-External-Sites anchor #5171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Fix the use of the #Visiting-External-Sites anchor #5171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43b9d45
Fix the use of the #Visiting-External-Sites anchor
rick-a-lane-ii Apr 7, 2023
60af8b9
Merge branch 'main' into main
jaffrepaul Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/faq/questions/using-cypress-faq.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ For further detail see the

Don't try to use your UI to check email. Instead opt to programmatically use 3rd
party APIs or talk directly to your server. Read about this
[best practice](/guides/references/best-practices#Visiting-external-sites) here.
[best practice](/guides/references/best-practices#Visiting-External-Sites) here.

:::

Expand Down
2 changes: 1 addition & 1 deletion docs/guides/guides/cross-origin-testing.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ than your superdomain, which can be safely tested with

We've written several other guides specifically about handling this situation.

- [Best Practices: Visiting external sites](/guides/references/best-practices#Visiting-external-sites)
- [Best Practices: Visiting external sites](/guides/references/best-practices#Visiting-External-Sites)
- [Web Security: Common Workarounds](/guides/guides/web-security#Common-Workarounds)
- [Recipes: Logging In - Single Sign On](/examples/recipes#Logging-In)
- [Guides: Amazon Cognito Authentication](/guides/end-to-end-testing/amazon-cognito-authentication)
Expand Down
4 changes: 2 additions & 2 deletions docs/guides/guides/web-security.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ cy.get('selector').should('exist') // Cypress errors

We do not recommend visiting a superdomain that you don't control in your tests
which you can read more about
[here](/guides/references/best-practices#Visiting-external-sites)
[here](/guides/references/best-practices#Visiting-External-Sites)

However, if you control this superdomain, either by owning the hosted instance
or by other means, we recommend testing this superdomain with `cy.origin`.
Expand Down Expand Up @@ -395,7 +395,7 @@ cy.origin('http://some.superdomain.com', () => {
Sometimes, when using `cy.origin` and especially with websites that are not
under your immediate test control, cross-origin errors may still tend to creep
up. We don't recommend visiting or interacting with sites you
[do not control](/guides/references/best-practices#Visiting-external-sites).
[do not control](/guides/references/best-practices#Visiting-External-Sites).
However, if this is necessary, most of these issues can usually be remedied by
applying` the
[modify obstructive third-party code](/guides/references/experiments#Configuration)
Expand Down