Skip to content

fix: patch docusaurus scroll behavior to fix anchors not working #5192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2023
Merged

fix: patch docusaurus scroll behavior to fix anchors not working #5192

merged 2 commits into from
Apr 14, 2023

Conversation

elylucas
Copy link
Contributor

No description provided.

@elylucas elylucas requested a review from jaffrepaul April 14, 2023 17:50
jaffrepaul
jaffrepaul approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@jaffrepaul jaffrepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem to be doing the trick.

Do you think it's some kind kind of test for this? Just thinking if anything changes in the future.

@elylucas
Copy link
Contributor Author

Seem to be doing the trick.

Do you think it's some kind kind of test for this? Just thinking if anything changes in the future.

ya lets sync next week to discuss

@elylucas elylucas merged commit 6c95189 into main Apr 14, 2023
@elylucas elylucas deleted the patch-docusaurus-scroll branch April 14, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jaffrepaul jaffrepaul jaffrepaul approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elylucas @jaffrepaul