Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select component implementations inconsistently render selection styles in dropdown #21768

Closed
sync-by-unito bot opened this issue May 30, 2022 · 1 comment · Fixed by #23894
Closed

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022

Summary

Our Select component is used in a few places:

Most do not show the current value as selected in the dropdown with the visible checkmark and other styling, with the exception of the "Front-end Framework" dropdown in SelectFwOrBundler. However, it seems like they all should show these selection styles.

The Select currently expects the selected options to be provided with an isSelected property, which is not uniformly provided today. It seems like we could use the inner TabList's selection APIs to keep this synchronized better.

Acceptance Criteria

  • Select implementations within these files should consistently show their selected items as selected in the dropdown
  • Percy snapshots should be added for these scenarios

Screen Shot 2022-03-17 at 5 00 09 PM
Screen Shot 2022-03-17 at 5 17 04 PM
Screen Shot 2022-03-17 at 5 07 38 PM
Screen Shot 2022-03-17 at 5 07 22 PM
Screen Shot 2022-03-17 at 5 00 25 PM

┆Issue is synchronized with this Jira Bug by Unito
┆Attachments: Screen Shot 2022-03-17 at 5.00.09 PM.png | Screen Shot 2022-03-17 at 5.00.25 PM.png | Screen Shot 2022-03-17 at 5.07.22 PM.png | Screen Shot 2022-03-17 at 5.07.38 PM.png | Screen Shot 2022-03-17 at 5.17.04 PM.png
┆author: Tyler Biethman
┆epic: UI/UX Improvements
┆friendlyId: UNIFY-1375
┆priority: Low
┆sprint: Backlog
┆taskType: Bug

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 10, 2022

Released in 11.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v11.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants