Close button not working on Choose browser page v13.6.4

[sirkkalap]

Current behavior

Clicking close button closes the browser but relaunches it immediately after closing it.

Desired behavior

Browser should stay closed after clicking Close button.

Test code to reproduce

The issue is in the UI and reproduced by MikeMC399 and cy.david in discord [1].

[1] https://discord.com/channels/755913899261296641/1202942184542965823

Cypress Version

v13.6.4

Node version

v18.7.1

Operating System

MacOS Sonoma 14.3 (23D56)

Debug Logs

No response

Other

The issue was not present at 13.6.2 according to discussion at discord (see above).

[MikeMcC399]

This is a regression from cypress@13.6.3.

Reproducible also on Ubuntu 22.04 and Windows 11 with Node.js 20.11.0.

Repro steps:

npx cypress open --e2e --browser electron

Then hit Close button.

[jennifer-shehane]

I can't recreate this on Mac Sonoma. Someone on our team did experience though, we thought it was a fluke, but I guess not.

[mschile]

I was able to reproduce the issue and tracked it down to being introduced in commit cdc42b9.

[MikeMcC399]

@mschile

I was able to reproduce the issue and tracked it down to being introduced in commit cdc42b9.

• Good to hear that you have tracked this down! It seems that the commit comes from refactor: use cypress design button in launchpad #27795. This PR was not mentioned in the Changelog anywhere.

[elevatebart]

@mschile can you share the steps? Machine? Browser? I want to have a look at this issue I introduced.

Own my mistakes...

[MikeMcC399]

@elevatebart

can you share the steps? Machine? Browser? I want to have a look at this issue I introduced.

See #28852 (comment) above for repro steps.

[elevatebart]

What happens

When one clicks on the close Button, it has the wrong button type so, after closing the browser, the click re-submits the form, re-opening it.

Why does it re-submit now while before this change everything was fine? Html buttons have type="submit" by default. and version 0.11.0 of the design system does not implement the type attribute properly.

Why it happened

I made sure the bug was fixed in the design system and was implemented in full in my branch before moving the PR out of draft, but I expect that a bad merge rolled back the dependency to the button. As of now, the app and the launchpad still use 2 different version of the button. They are both outdated and with documented issues.

How to fix

Update both dependency numbers to the latest version (see #28860)

How to avoid it happening again

Add a component test to check that each button triggers the right event and only the right event.

[MikeMcC399]

I checked with the pre-release version from 4b6cafa#comments on Ubuntu 22.04 x64 and the fix looks fine. 🎉

[cypress-bot]

Released in 13.6.5.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.5, please open a new issue.