Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(component-testing): start dev server event typings #14855

Merged
merged 6 commits into from
Feb 2, 2021
Merged

fix(component-testing): start dev server event typings #14855

merged 6 commits into from
Feb 2, 2021

Conversation

elevatebart
Copy link
Contributor

closes CT-252

Fixes and tightens the types of dev-server:start

I think it could use a bit of factoring to avoid repeating the type definitions.
This can be accomplished in a future PR.

Screen Shot 2021-02-01 at 4 36 16 PM

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 1, 2021

Thanks for taking the time to open a PR!

JessicaSachs
JessicaSachs suggested changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@JessicaSachs JessicaSachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typing the server prop

cli/types/cypress.d.ts Outdated Show resolved Hide resolved
@cypress
Copy link

cypress bot commented Feb 1, 2021 •
edited
Loading


Test summary

9310 • 0 • 118 • 3 • Flakiness 1

Run details
Project cypress
Status Passed
Commit c1644b0
Started Feb 2, 2021 8:06 PM
Ended Feb 2, 2021 8:18 PM
Duration 12:22 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️

Flakiness

cypress/integration/retries.ui.spec.js 1 Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

lmiller1990
lmiller1990 reviewed Feb 1, 2021
View reviewed changes
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments

cli/types/cypress.d.ts Outdated Show resolved Hide resolved
cli/types/cypress.d.ts Outdated Show resolved Hide resolved
@lmiller1990 lmiller1990 self-requested a review February 1, 2021 23:53
@elevatebart elevatebart changed the title fix: start dev server event typings fix(component-testing): start dev server event typings Feb 2, 2021
@elevatebart elevatebart merged commit 6dfaa23 into feat/component-testing Feb 2, 2021
@elevatebart elevatebart deleted the feat/evergreen-typings branch February 2, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmiller1990 lmiller1990 lmiller1990 approved these changes

@JessicaSachs JessicaSachs JessicaSachs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elevatebart @JessicaSachs @lmiller1990