refactor: in the frontend-shared package use the design system button #28791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 failed and 31 flaky tests on run #53807 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > saves the filter when navigating to a spec and back |
Test Replay
Screenshots
|
|
runs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| ... > displays a list of recorded runs if a run has been recorded |
Test Replay
Screenshots
|
|
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Test Replay
Screenshots
|
|
e2e/origin/origin.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| cy.origin > withBeforeEach > passes runnable state to the secondary origin on retry |
Test Replay
|
|
e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| ... > throws when foo cannot resolve |
Test Replay
|
|
commands/files.cy.js • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| ... > has implicit existence assertion, retries and throws a specific error when file does not exist for null encoding |
Test Replay
|
|
The first 5 flaky specs are shown, see all 17 specs in Cypress Cloud.
Review all test suite changes for PR #28791 ↗︎
…tton-in-frontend-shared
|
This PR has not had any activity in 180 days. If no activity is detected in the next 14 days, this PR will be closed. |
elevatebart
deleted the
elevatebart/refactor/use-design-system-button-in-frontend-shared
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to cypress-io/cypress-design#189
Assumptions
pendingis alwaysdisabledso the variants are mergedsmis 24 px tall, set the size accordinglylgis 40 px tall, set the size accordinglysize="32"when there is noneCopyButtonneeded to be changed a little to avoid mixups:outline=>outline-light