Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: in the frontend-shared package use the design system button #28791

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

elevatebart
Copy link
Contributor

@elevatebart elevatebart commented Jan 24, 2024

Related to cypress-io/cypress-design#189

Assumptions

  • pending is always disabled so the variants are merged
  • size sm is 24 px tall, set the size accordingly
  • size lg is 40 px tall, set the size accordingly
  • the default size is different so I added size="32" when there is none
  • instead of using prefix and suffix icons, I use declarative html, the way it is described in the documentation
  • The CopyButton needed to be changed a little to avoid mixups: outline => outline-light

@elevatebart elevatebart marked this pull request as ready for review January 29, 2024 15:48
Copy link

cypress bot commented Jan 29, 2024

1 failed and 31 flaky tests on run #53807 ↗︎

1 28973 1343 0 Flakiness 31

Details:

Merge branch 'develop' into elevatebart/refactor/use-design-system-button-in-fro...
Project: cypress Commit: c68f7777a6
Status: Failed Duration: 21:57 💡
Started: Jan 30, 2024 7:03 PM Ended: Jan 30, 2024 7:25 PM
Failed  cypress/e2e/specs_list_e2e.cy.ts • 1 failed test • app-e2e

View Output

Test Artifacts
... > saves the filter when navigating to a spec and back Test Replay Screenshots
Flakiness  runs.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
... > displays a list of recorded runs if a run has been recorded Test Replay Screenshots
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Screenshots
Flakiness  e2e/origin/origin.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
cy.origin > withBeforeEach > passes runnable state to the secondary origin on retry Test Replay
Flakiness  e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > throws when foo cannot resolve Test Replay
Flakiness  commands/files.cy.js • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > has implicit existence assertion, retries and throws a specific error when file does not exist for null encoding Test Replay

The first 5 flaky specs are shown, see all 17 specs in Cypress Cloud.

Review all test suite changes for PR #28791 ↗︎

@elevatebart elevatebart marked this pull request as draft January 30, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant