-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clicking 'Re-run all jobs' in GHA kicks off workflow, but marks tests as passing with 'Run Finished' but tests are not triggered #510
Comments
@mmsjd you mention that "'Re-run all jobs' worked prior to this" what do you mean by prior to this? Has this config file changed since then? What did things look like when you had everything working? I am trying to figure out what has changed to dry and debug your issue. Also, you are using v2 of the GitHub Action, but the latest version is 3.0.2. Can you try and use the latest version and see if that helps?
Also, I don't suppose this repo is publicly available, is it? It would be great to take a closer look at things if possible. |
Unfortunately, the repo is not public, but I have temporarily enabled access to Cypress dashboard runs. I have also tried a million different things trying to get 'Re-run all jobs' to work. Most recent change was switching our Cypress run command from using |
No luck.
|
I will look further into this. In the meantime you can disable publicly sharing your Cypress runs. |
can you turn on debugging and paste in the output here for me to take a look at it? https://github.com/cypress-io/github-action#debugging There is also some additional information in the older issue you linked originally: #147 |
@robertguss thank you so much for looking into this! is there a process in particular you are looking for? i'd like to narrow the scope as the debug log is roughly 28k lines. |
oh my. I am not looking for the Cypress debug log , env:
DEBUG: 'cypress:*' I am wanting to see the debug log from the action itself - name: Cypress tests with debug logs
uses: cypress-io/github-action@v2
env:
DEBUG: '@cypress/github-action' like we have it in the readme and example here: https://github.com/cypress-io/github-action#debugging feel free to attach it as a file instead of pasting it all in a comment. |
Here you go. |
@mmsjd looking through the logs now. I am going to try and see if I can recreate this same behavior on my end and will keep you posted. I am not quite sure what is going just yet. Thank you for your help and patience. I will keep you posted. |
@mmsjd can you do me a favor and modify your
Can you please remove the Let me know the results. Also, within this script you are passing in a lot of flags, which you also have enabled via the GHA workflow config which does this for you. I don't think this would cause your issue, but we can clean that up later. For example, in the your script you have with:
record: true
parallel: true So a lot of this is redundant, but again I don't think is the cause of your issue. just wanted to point that out. |
@mmsjd I was able to recreate the issue in this PR: cypress-io/cypress-realworld-app#1200 I am trying some things to see if I can fix it. |
Good morning! Reducing
|
@mmsjd I was able to solve the issue by removing the --ci-builid from the |
ok sorry to confuse you, but update your
|
Sans
|
oh boy. in my PR in our Real World App I was able to recreate your issue and then by removing that flag, The re-runs work as expected. check this out: cypress-io/cypress-realworld-app#1200 |
I only see initial run attempt. I don't see dropdown to toggle between initial run vs re-run. Assuming because I don't have the right permissions? |
I am on this link: https://github.com/cypress-io/cypress-realworld-app/runs/5305766039?check_suite_focus=true re-run all jobs |
For https://github.com/cypress-io/cypress-realworld-app/runs/5306703582?check_suite_focus=true#step:5:117 run-attempt #2 is also showing |
@mmsjd still looking into this and will be in touch when I have an update |
@mmsjd is there any way you can create a public repo, that recreates the issue you are seeing? It is really hard to debug this without actually seeing your code and the problem firsthand. Can you create a simple sample project, with your GitHub Action config so I can see this issue firsthand? |
Hello! I posted the entire Cypress portion of our Github Actions yaml here. For https://github.com/cypress-io/cypress-realworld-app you need to setup one of your tests to always fail then attempt re-run. You will find the runUrl in the initial test run attempt and all subsequent runs share the same runUrl. This should not be the case. There should be a new runUrl if I trigger a re-run in GHA. |
this is helpful. thank you. |
i am having the same issue. |
Good evening! I just wanted to follow up. Please let me know if there's anything I can possibly provide to help assist in debugging. Thank you! |
Sorry I haven't been around the past couple of days, busy with work. I will try and look into this again today and keep you posted. |
@mmsjd have you tried this? https://github.com/cypress-io/github-action#custom-build-id |
Hi! No, I have not. I can try. Will report back (likely early next week). |
Hello! Happy to report using cutom-build-id solution worked. Thank you so much for all your help. |
@mmsjd awesome! glad it worked and my pleasure. |
For anyone who is looking to add a new custom-build-id: https://medium.com/@blakenewman/hey-no-problem-actually-github-has-made-an-alternative-way-to-achieve-this-possible-and-is-a-bit-e08bd574f6c6 |
Hi - this doesn't work if you're using multiple containers. It just runs the test suite multiple times as they all have a different id, do we have a solution for that? |
You've replied to an old closed issue, so I'm not sure what you are referring to exactly when you say it doesn't work.
|
Hello!
I am seeing behavior similar to Tests not ran: Getting "Run finished" immediately when re-running tests #147 where clicking 'Re-run all jobs' in Github Actions kicks off a workflow, but marks all Cypress tests as passing with 'Run Finished' but tests are not triggered.
Initial run details:
Re-run details:
Additional notes:
I'm not finding
jobId
in the logs and see thatciBuildId
is either set to""
or'-'
.GHA re-run debug log:
We are using Cypress
9.5.0
with the following workflow file:yarn test:regression
script details:cypress run --group specs/regression --spec 'cypress/specs/regression/**/*' --ci-build-id $GIT_COMMIT-$BUILD_NUMBER --config-file cypress.json --tag 'regression' --browser chrome --parallel --record"
We noticed 'Re-run all jobs' failing to trigger tests roughly about a month ago. I've been sporadically trying to debug the issue since, but am at a loss. 'Re-run all jobs' worked prior to this. Any help or insight on how to resolve this would be greatly appreciated!
The text was updated successfully, but these errors were encountered: