Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update cypress to 13.3.2 #1061

Closed
wants to merge 1 commit into from
Closed

chore(deps): update cypress to 13.3.2 #1061

wants to merge 1 commit into from

Conversation

Julien-Marcou
Copy link

This PR updates the examples to Cypress 13.3.2 released Oct 18, 2023.

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2023

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link

@MikeMcC399
Copy link
Collaborator

@Julien-Marcou

  • Could you please clarify if the Cypress team asked you to submit this PR or if it was your own idea? I ask this because I have submitted PRs for each of the previous 20 releases since Cypress 12.8.0 in March of this year.
  • Are you intending to carry out this maintenance task for future releases of Cypress or is this a one-off submission?
  • Since you have not previously contributed to this repository the workflows that could check whether the PR is successful are blocked and need to be approved.

@Julien-Marcou
Copy link
Author

Julien-Marcou commented Oct 20, 2023

@Julien-Marcou

  • Could you please clarify if the Cypress team asked you to submit this PR or if it was your own idea? I ask this because I have submitted PRs for each of the previous 20 releases since Cypress 12.8.0 in March of this year.
  • Are you intending to carry out this maintenance task for future releases of Cypress or is this a one-off submission?
  • Since you have not previously contributed to this repository the workflows that could check whether the PR is successful are blocked and need to be approved.

@MikeMcC399

  • It was my idea
  • No I don't intend to carry out this maintenance
  • Yes, I was expecting the PR to be blocked until someone approved it

This PR is in line with several PRs I'm doing across some GitHub/Cypress repositories, as Node 20.8.1, which is a security release, has been released a few days ago, I wanted to sync all the dependencies of one of my project to align everything with at least Node 20.8.1 and Cypress 13.3.2

I wanted to then update the docker image example in an upcoming PR, with something like that:

     # from https://hub.docker.com/r/cypress/browsers/tags
     container:
-      image: cypress/browsers:node-20.5.0-chrome-114.0.5735.133-1-ff-114.0.2-edge-114.0.1823.51-1
+      image: cypress/browsers:node-20.8.1-chrome-118.0.5993.88-1-ff-118.0.2-edge-118.0.2088.46-1

I know the changes are only for examples (so there is no real security issue here), but I thought I could take the opportunity to change them at the same time 🙂

@jennifer-shehane
Copy link
Member

Thanks @Julien-Marcou

@MikeMcC399

This comment was marked as resolved.

@Julien-Marcou
Copy link
Author

Rebased 👍

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399
Copy link
Collaborator

@Julien-Marcou

Yesterday, Oct 23, 2023, Cypress 13.3.3 was released, so this PR is now obsoleted and should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants