-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update serve packages flagged by snyk #673
Conversation
9ebfb81
to
5b428cc
Compare
Hi @jaffrepaul I noticed there is a breaking change in serve v13 which changes the default port from 5000 to 3000. Any tests previously relying on the default 5000 would need to add the parameter
(I checked, and major projects, like React and Angular are also still using yarn classic.) |
Just to check that my assessment was right, I ended up fixing the issues here, so if you'd like a PR piggy-backed on your draft PR please let me know. Here are the differences: |
I've submitted PR #682 to fix this one. My PR fails the snyk security check. I don't know why though, since I can't view the details, not being a member of the cypress-io organization. |
1b8854f
to
3805150
Compare
|
I suggest you also revert 3805150 with the ineffective whitelisting. |
d58f683
to
034103d
Compare
Thanks @MikeMcC399 adding it to the whitelist was a simple prayer in the interest of time. Appreciate the follow up here! |
No description provided.