Fixed conversion from DictNode to map #4231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da-woods
commented
Jun 16, 2021
scoder
reviewed
Jun 16, 2021
Cython/Compiler/ExprNodes.py
Outdated
Comment on lines
8869
to
8872
| elif dst_type.is_cpp_class and dst_type.can_coerce_from_pyobject(env): | ||
| # not guaranteed that we can coerce from this particular PyObject, but worth a try | ||
| # Note that other places seem to try calling create_from_py_utility_code instead | ||
| return CoerceFromPyTypeNode(dst_type, self, env) |
There was a problem hiding this comment.
Shouldn't we just call ExprNode.coerce_to() as a general fallback?
(BTW, can_coerce_from_pyobject() was just added later than create_from_py_utility_code() to avoid always doing the actual work, if all we need is know if it can be done.)
There was a problem hiding this comment.
It seems to work. It's possible there might be some tests looking for the specific error message that need accounting for... we'll see
Co-authored-by: scoder <stefan_ml@behnel.de>
da-woods
commented
Jun 17, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one part of #4228
I also added tests for the equivalent list and tuple operations, but they seemed to work as is.