Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'cytoscape-node-edge-html-label' to list of UI extensions #3245

Closed
4 tasks
laikmokashi opened this issue May 28, 2024 · 17 comments
Closed
4 tasks

Add 'cytoscape-node-edge-html-label' to list of UI extensions #3245

laikmokashi opened this issue May 28, 2024 · 17 comments
Assignees
Milestone

Comments

@laikmokashi
Copy link

laikmokashi commented May 28, 2024

Description of new feature

New feature provide you freedom to create an html and positioned it on any place on edge or on node.

Motivation for new feature

having HTML on edge and on node can provide better ui and similarly can provide better understanding of overall structure. It also help you with having adding events on nodes and lables
image

For reviewers

Reviewers should ensure that the following tasks are carried out for incorporated issues:

  • Ensure that the reporter has adequately described their idea. If not, elicit more information about the use case. You should iteratively build a spec together.
  • Ensure that the issue is a good fit for the core library. Some things are best done in extensions (e.g. UI-related features that aren't style-related). Some things are best done by app authors themselves -- instead of in Cytoscape libraries.
  • The issue has been associated with a corresponding milestone.
  • The commits have been incorporated into the unstable branch via pull request. The corresponding pull request is cross-referenced.
@mikekucera
Copy link
Contributor

Take a look at the cytoscape-layers extension.

https://www.npmjs.com/package/cytoscape-layers

@laikmokashi
Copy link
Author

@mikekucera Sorry i am new to open source contribution but can you help me with which UI extension exactly help me to render html on edges rather than just a labeled text. I have seen it is available for nodes but i didn't get anything for edges , hence i have created new Ui library with the help of node-html-label .

url : https://www.npmjs.com/package/cytoscape-node-edge-html-label
sample project : https://github.com/laikmokashi/cytoscape-node-edge-html-lable-example

can you please have a look on it and tell me if we can add it in UI extensions , because i have faced lots of issue to achieve that functionality in my project

@mikekucera
Copy link
Contributor

Sorry, I'm not sure what you're asking for. Did you create a new extension or did you modify an existing extension? The repository link on the NPM page is broken so I'm not sure.

HTML is outside of the scope of cytoscape.js itself, and is best done in an extension. If you have a new extension we can add it to the list of extensions in the docs. But if its a copy of an existing extension (node-html-label?) with modifications then the new functionality should probably be a PR contribution to that extension's repository.

@laikmokashi
Copy link
Author

yes i have used source code of node-html-lable only but with this fuctionality i thinks it can act as an complete new library because lot many changes are done for that.
what should i do then ? should i add PR contribution or it should add as an new extention only?

@mikekucera
Copy link
Contributor

Ideally this should be a modification to node-html-label. However it doesn't look like that repository is being actively maintained, so that might not be an option. If you want I can add this new extension to the list of UI extensions in the docs.

@laikmokashi
Copy link
Author

Allow me some time i will test all scenario again and will create better project so people can get better idea to use it.
Thank You .
Once done can i connect you on this thread only ?

@mikekucera
Copy link
Contributor

yes, thanks

@laikmokashi
Copy link
Author

Hello @mikekucera
I have tested the code for extension and also created demo on it. i have published the demo which is visible to everyone.
can you please have a look on it once and if all looks good to you please add this package in UI extension in docs.
npm link :https://www.npmjs.com/package/cytoscape-node-edge-html-label.

please let me know if anything from my side is needed.

Thanks

@mikekucera mikekucera changed the title Providing Html on edge and its respective position on edge. Add 'cytoscape-node-edge-html-label' to list of UI extensions May 31, 2024
@mikekucera mikekucera reopened this May 31, 2024
@mikekucera
Copy link
Contributor

Ok I'll take a look soon. Thanks.

@maxkfranz
Copy link
Member

@laikmokashi, would you link to the github repo?

@laikmokashi
Copy link
Author

@maxkfranz where do i need to link it ? Can you please help me with it

@maxkfranz
Copy link
Member

maxkfranz commented Jul 9, 2024 via email

@maxkfranz
Copy link
Member

@laikmokashi
Copy link
Author

@maxkfranz Sorry for that , It was private previously. I have made it public now. I hope you will be able to open that repo now .

Thanks

@maxkfranz maxkfranz self-assigned this Aug 14, 2024
@laikmokashi
Copy link
Author

Hi @maxkfranz @mikekucera is there any update on this ? is there any issue ?

@mikekucera
Copy link
Contributor

I've added your extension to the list of extensions in the documentation. It will show up when we release the next version of cytoscape.js. Sorry for the wait. Thank you.

@mikekucera mikekucera added this to the 3.30.3 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants