Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor API for NGFF datasets #31
Refactor API for NGFF datasets #31
Changes from 82 commits
a63c55f
7445eeb
102ba31
4c8f77d
f57a368
c1a4b02
4e42e88
245c23c
fe91734
3e81089
0b8c9c0
fad0225
279d04d
c25151c
2db7119
c071835
1842570
63ffda2
eae58b4
268959a
4dcbf00
dff09f2
beff804
09d953e
c9cbe27
a2f0267
0d6fa32
641459a
8bef5dc
4692bae
74ed6e0
dc00551
ca1681a
23e3e0c
953bc9b
2ce0334
763138e
5003887
acc800a
dd7e6d7
d6f886a
a43d71c
a7f792d
4330601
a0bdfe7
6a7ee3f
68daef1
b01c5e6
3d62e6f
2784672
e66390a
34d20bc
54ac842
87f7ee9
d6efd5c
6444f9c
a893cf0
ccab859
fc2fc2e
4a7b8cb
9ae5ec3
93b57bd
21b89b8
31d4489
d70248c
e1347a9
403f5ec
b83be4d
1c3128b
df3a823
d104024
a51ab2a
a0b04ba
0723b33
7a5e9f6
c17b81e
90cdbc2
9c6d0d2
686b0af
0e995fd
92fa0db
94a20f9
ea17a61
4f58916
efabd82
7c20657
a02ceba
2789ea2
0255beb
0e0b134
919d951
c9ee998
036f205
8dd85c7
9219273
a02a948
702e945
c787958
b655f69
a8300d4
ae5cd17
a4a83ae
6657abb
6d0ba4c
b9516b1
61237f9
e9e83eb
2293405
b08d107
7dd36c5
9213136
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since OMEZarr is by definition single-position ND array, the syntax of assigning a 5D array into a zeroth index of dataset is non-intuitive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The data structure that mimics access pattern of napari will be lot more intuitive for users.
For example,
dataset.channels['DAPI'].data
is the numpy array whose shape, size, dtype can be examined.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it is single-position by definition, it is possible (and the intended use case) to have multiple items in the Zarr store. For example each resolution level in a pyramid is an array, and the labels are in a member Zarr group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the NGFF specification and the current API of an
OMEZarr
dataset is identical to a position in the HCS hierarchy. In fact, a position in an HCS Zarr store can be opened in iohub and napari-ome-zarr as if it was a standalone dataset. I think it is beneficial to keep them synchronizedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per our discussion,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed
OMEZarr
toOMEZarrFOV
to show its single-FOV nature, and edited docstring to further explain its intended use.This file was deleted.