Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing guidelines #32

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Contributing guidelines #32

merged 2 commits into from
Jan 30, 2023

Conversation

ziw-liu
Copy link
Collaborator

@ziw-liu ziw-liu commented Jan 27, 2023

Closes #30.

Please feel free to push to this branch directly!

@ziw-liu ziw-liu marked this pull request as ready for review January 27, 2023 22:56
@ziw-liu ziw-liu self-assigned this Jan 27, 2023
@ziw-liu ziw-liu added this to the 0.0.1 milestone Jan 27, 2023
@ziw-liu ziw-liu added the documentation Improvements or additions to documentation label Jan 27, 2023
Copy link
Member

@JoOkuma JoOkuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left a small comment regarding a typo.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@AhmetCanSolak AhmetCanSolak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @ziw-liu !

Copy link
Contributor

@talonchandler talonchandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ziw-liu, look great.

@ziw-liu ziw-liu merged commit a5f24a2 into main Jan 30, 2023
@ziw-liu ziw-liu deleted the contribution-guide branch January 30, 2023 23:26
@ziw-liu ziw-liu mentioned this pull request Feb 15, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contribution guide
4 participants