Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Úkol 2 - Lubomír Jiřišta #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Úkol 2 - Lubomír Jiřišta #19

wants to merge 2 commits into from

Conversation

lumitor2
Copy link

Jiřišta: Do projektu přidáno stránkování a základní draft breadcrumbs, které by bylo dobré rozšířit na volitelné parametry.

@@ -7,3 +7,13 @@ services:
# service_name:
# class: AppBundle\Directory\ClassName
# arguments: ["@another_service_name", "plain_value", "%parameter_name%"]
product_repository:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pecka super :)

@vasekboch
Copy link
Collaborator

U commitu Added pagination. Data loading moved to repositories. máš dvě věci v jednom. Nebál bych se to oddělit. Kdybychom vyvíjeli nějaký reálný produkt, tak hypoteticky, kdyby si v té části se stránkováním měl nějaký fatální bug. Mohli bychom mergnout aspoň první commit, aby ho z toho mohl těžit zbytek týmu :)

@vasekboch
Copy link
Collaborator

Škoda, že chybí stránkování i na stránce s kategoriemi. Ale neva. Bylo by to podobné. Plus na drobečkovku.

@vasekboch vasekboch closed this Oct 16, 2016
@vasekboch vasekboch changed the title 2nd homework Úkol 2 - Lubomír Jiřišta Oct 16, 2016
@klatys klatys reopened this Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants