Skip to content
This repository was archived by the owner on Apr 27, 2021. It is now read-only.

Replace continue with continue 2 within switch PHP 7.3 #11

Merged
merged 2 commits into from
Jan 10, 2019
Merged

Replace continue with continue 2 within switch PHP 7.3 #11

merged 2 commits into from
Jan 10, 2019

Conversation

daniel-de-wit
Copy link
Contributor

Fixes #10

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0004%) to 99.333% when pulling e6d06b7 on daniel-de-wit:master into 0363132 on czim:master.

@coveralls
Copy link

coveralls commented Jan 9, 2019

Coverage Status

Coverage remained the same at 99.332% when pulling fe53d91 on daniel-de-wit:master into 0363132 on czim:master.

@czim
Copy link
Owner

czim commented Jan 10, 2019

Funny story: I was actually under the incorrect impression that continue behaved in the C-like way!
Hence my use of it. If I wanted break behaviour here, I would've preferred using that instead.

So though it did not matter here, this was a bug waiting to happen. All thanks to PHP-weirdness. Useful and interesting to learn :D

@czim czim changed the title Replace continue with breaks within switch PHP 7.3 Replace continue with continue 2 within switch PHP 7.3 Jan 10, 2019
@czim czim merged commit 5120456 into czim:master Jan 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants