UAVO: Add description element to fields, add tooltips in UAVO Browser #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracernz
force-pushed
the
uavo-howtomakefly
branch
from
67d5a79
to
1ed113a
Compare
| */ | ||
| QString UAVObjectGeneratorGCS::escape_raw_string(QString raw) | ||
| { | ||
| return raw.replace("\\", "\\\\").replace("\"", "\\\"").simplified(); |
There was a problem hiding this comment.
The QString::simplified function replaces all whitespace chars with a single space, and gobbles consecutive whitespace into a single space.
tracernz
force-pushed
the
uavo-howtomakefly
branch
4 times, most recently
from
3f8d41a
to
3bbeab4
Compare
|
I've read but not tested this. Probably at least a couple token desc's would be nice to merge as part of this PR. Also need to verify that it doesn't break the python API |
tracernz
force-pushed
the
uavo-howtomakefly
branch
from
9b77754
to
3ea7528
Compare
|
Rebased to next. |
|
jenkins, test this please |
|
You or I should do the python stuff as part of this PR. |
And tooltips in GCS UAVOBrowser Fixes d-ronin#41
It already was anyway in addition to our attempted wrapping control (which just resulted in unnecessary wraps being inserted).
ActuatorSettings AttitudeSettings HomeLocation TaskInfo
tracernz
force-pushed
the
uavo-howtomakefly
branch
from
7c7b363
to
7817492
Compare
|
Added python code to parse descriptions, rebased on next. |
mlyle
added
status/ready-for-merge
and removed
status/requires-test
status/work-in-progress
labels
|
pending jenkins |
mlyle
added a commit
that referenced
this pull request
Nov 29, 2015
UAVO: Add description element to fields, add tooltips in UAVO Browser
This was referenced Jan 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going to sleep but then I kept thinking about this :-P. Fixes #41.
UAVOs can now have an optional description element inside each field. This field is used in the GCS object browser to display tooltips on each UAVO field.
No field descriptions are actually defined in this PR (an issue will be created once merged). To test you will need to add a description to one or more fields, e.g. in https://github.com/d-ronin/dronin/blob/next/shared/uavobjectdefinition/actuatorsettings.xml#L4: