Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing toolbar when returning from fullscreen #961

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

cocoon
Copy link
Contributor

@cocoon cocoon commented Jan 8, 2021

The toolbar icons get moved into a "3 points menu" to the far right when exiting fullscreen for me.

To reproduce:

  • Opening an image (see all toolbar icons on top and aligned to the middle)
  • press F11 to enter Fullscreen
  • press F11 again to exit Fullscreen
  • all Toolbar icons are gone and moved into an own menu to the far right

Tried the following versions, all have the problem:
ImageGlass_Moon_7.6.11.18_x64
ImageGlass_8.0.12.8_x64
ImageGlass dev self compiled (07.01.2021)

Copy link
Owner

@d2phap d2phap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cocoon

@d2phap d2phap merged commit df8b0f5 into d2phap:develop Jan 8, 2021
@cocoon
Copy link
Contributor Author

cocoon commented Jan 8, 2021

I discovered one more problem:

When maximizing and restoring back the same happens.

How about restoring it here instead?

https://github.com/d2phap/ImageGlass/blob/develop/Source/ImageGlass/frmMain.cs#L2992

            else if (m.Msg == 0x0005) // WM_SIZE
            {
                // Update toolbar icon according to the new size
                LoadToolbarIcons(forceReloadIcon: true);

                toolMain.UpdateAlignment();
            }

@d2phap
Copy link
Owner

d2phap commented Jan 8, 2021

This event will be triggered every time window resized: https://docs.microsoft.com/en-us/windows/win32/winmsg/wm-size

Sent to a window after its size has changed.

Putting here will cause performance problem bcuz IG will reload all toolbar icons

@cocoon
Copy link
Contributor Author

cocoon commented Jan 8, 2021

Yes that is what I was thinking, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants