Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add opt-in support for device pixel ratio to d3fc-canvas #1126

Closed
ColinEberhardt opened this issue Aug 9, 2018 · 0 comments
Closed

Add opt-in support for device pixel ratio to d3fc-canvas #1126

ColinEberhardt opened this issue Aug 9, 2018 · 0 comments
Assignees
@chrisprice
Labels
bug d3fc-element

Comments

@ColinEberhardt
Copy link
Member

From @chrisprice on July 20, 2017 15:26

window.devicePixelRatio specifies the relationship between device pixels and css pixels. We should allow users to opt-in to using this value as a multiplier when measuring the canvas size.

We need to make the behaviour opt-in so that we that we don't break things like font sizes for uninterested parties e.g both axes have the same text size but one is rendered with SVG and the other canvas -

image

Relates to #1071

Copied from original issue: d3fc/d3fc-element#30
@chrisprice chrisprice mentioned this issue Aug 21, 2018
Closed
@chrisprice chrisprice added the bug label Aug 22, 2018
@chrisprice chrisprice self-assigned this Aug 24, 2018
chrisprice added a commit to chrisprice/d3fc that referenced this issue Aug 24, 2018
@chrisprice
feat: add use-device-pixel-ratio attribute
224244d 
The surface will now throw if it detects elements have been added to it, ensure elements are added as descendants of the svg.

Fixes d3fc#1126.
Fixes d3fc#1125.
chrisprice added a commit to chrisprice/d3fc that referenced this issue Aug 24, 2018
@chrisprice
feat: add use-device-pixel-ratio attribute
6ed235b 
The surface will now throw if it detects elements have been added to it, ensure elements are added as descendants of the svg.

Fixes d3fc#1126.
Fixes d3fc#1125.
@chrisprice chrisprice mentioned this issue Aug 24, 2018
Merged
chrisprice added a commit to chrisprice/d3fc that referenced this issue Aug 24, 2018
@chrisprice
feat: add use-device-pixel-ratio attribute
e97326b 
The surface will now throw if it detects elements have been added to it, ensure elements are added as descendants of the svg.

Fixes d3fc#1126.
Fixes d3fc#1125.
chrisprice added a commit that referenced this issue Aug 24, 2018
@chrisprice
feat: add use-device-pixel-ratio attribute
3f8d78d 
The surface will now throw if it detects elements have been added to it, ensure elements are added as descendants of the svg.

Fixes #1126.
Fixes #1125.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisprice chrisprice

Labels
bug d3fc-element
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisprice @ColinEberhardt