Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepack #37

Merged
merged 2 commits into from
May 27, 2020
Merged

Prepack #37

merged 2 commits into from
May 27, 2020

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented May 26, 2020

  • npm: Add prepack script to run test-lite (per Complete coverage #34 (comment) )
  • Linting: Prefer const (these linting errors weren't caught because the PR that added them was merged before the linting-pkg-json merge and only changes are linted; going forward, future linting errors should be caught)

Btw, if you are only looking to see the files that are changed, it may be simpler to just run npm publish --dry-run. If you don't actually need pack, we could change the script where it runs to prepublishOnly.

@brettz9
Copy link
Contributor Author

brettz9 commented May 26, 2020

Btw, I see the Travis builds are failing since we are using the current ESLint 7 version which has a minimum of Node 10. Travis could be set up to downgrade to earlier ESLint versions, but it adds some complexity.

Btw, you may want to add the free open source integration for Travis so we can see the Travis status within PRs. I believe you can use this link to set it up: https://github.com/marketplace/travis-ci (as mentioned below on the page, it is free for open source)

@d3x0r
Copy link
Owner

d3x0r commented May 27, 2020

well I use pack so I can check the .tgz and make sure I didn't accidentally include any other stray files; 'sides that lets me keep a copy around for quick local install from tarball ...

Ya Travis integration can be added; I forgot how I set that up for another project; but I'll look into that shortly.

@d3x0r d3x0r merged commit ba3c59e into d3x0r:master May 27, 2020
@brettz9 brettz9 deleted the prepack branch May 27, 2020 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants